Discussion:
[omniORB] OmniOrb-4.1.1: Escaped identifiers inside unions breaks the omniidl compiler
Will Denissen
2007-10-19 19:04:30 UTC
Permalink
Dear Duncan,

When omniidl (omniOrb-4.1.1) parses the following idl code

Union my_union switch(long) {
case 0: long _long;
};

It will complain about ". Identifier 'long' clashes with keyword 'long' "

While the treatment for structs is OK.

struct my_struct {
long _long;
};


I have traced the bug in file ./src/tool/omniidl/cxx/idlast.cc line 1690

In which .declarator->identifier()... must be replaced by
.declarator->eidentifier().


Please check whether there are similar bugs with eidentifier.

Best regards,

Will Denissen.
--
The information contained in this communication and any attachments is confidential and may be privileged, and is for the sole use of the intended recipient(s). Any unauthorized review, use, disclosure or distribution is prohibited. Unless explicitly stated otherwise in the body of this communication or the attachment thereto (if any), the information is provided on an AS-IS basis without any express or implied warranties or liabilities. To the extent you are relying on this information, you are doing so at your own risk. If you are not the intended recipient, please notify the sender immediately by replying to this message and destroy all copies of this message and any attachments. ASML is neither liable for the proper and complete transmission of the information contained in this communication, nor for any delay in its receipt.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.omniorb-support.com/pipermail/omniorb-list/attachments/20071019/8c357e1d/attachment.htm
Duncan Grisby
2007-10-29 16:30:08 UTC
Permalink
Post by Will Denissen
When omniidl (omniOrb-4.1.1) parses the following idl code
Union my_union switch(long) {
case 0: long _long;
};
It will complain about ". Identifier 'long' clashes with keyword 'long' "
Thanks for the bug report. The fix you propose is the correct one, and
there are no other cases affected by the same issue. I'm about to check
in the fix.

Cheers,

Duncan.
--
-- Duncan Grisby --
-- ***@grisby.org --
-- http://www.grisby.org --
Loading...