[omniORB] Missing initialization in getpeername() call

[Peter Klotz]

Hello Duncan

The attached patch adds a missing variable initialization when calling getpeername().

The manpage of getpeername requires the third parameter to be set properly. All other getpeername calls in omniORB are correct.

Without this initialization we see assertion failures of this kind:


(gdb) bt
#0 0x0000003b19a30265 in raise () from /lib64/libc.so.6
#1 0x0000003b19a31d10 in abort () from /lib64/libc.so.6
#2 0x0000000000727e81 in omniORB::fatalException::fatalException ()
#3 0x0000000000719ea0 in omni::assertFail ()
#4 0x00000000007971ec in omni::tcpConnection::addrToURI ()
#5 0x00000000006eedda in omni::peerAddress ()
#6 0x00000000006efc37 in omni::sslEndpoint::AcceptAndMonitor ()
#7 0x000000000075dc8a in omni::giopRendezvouser::execute ()
#8 0x000000000070922d in omniAsyncWorker::real_run ()
#9 0x0000000000709695 in omniAsyncWorker::run ()
#10 0x00000000007a5b30 in omni_thread_wrapper ()
#11 0x0000003b1a60673d in start_thread () from /lib64/libpthread.so.0
#12 0x0000003b19ad3d1d in clone () from /lib64/libc.so.6


The patch should apply cleanly against SVN.

Regards, Peter.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: omniORB-4.1.5-20100715-getpeername.patch
Type: text/x-patch
Size: 587 bytes
Desc: not available
Url : http://www.omniorb-support.com/pipermail/omniorb-list/attachments/20101015/cd7d6e56/omniORB-4.1.5-20100715-getpeername.bin

[Duncan Grisby]

Post by Peter Klotz
The attached patch adds a missing variable initialization when calling getpeername().

Thanks. I had actually already fixed that, back in August.

Cheers,

Duncan.

[Peter Klotz]

Hello Duncan

Post by Duncan Grisby

Post by Peter Klotz
The attached patch adds a missing variable initialization when calling getpeername().

Thanks. I had actually already fixed that, back in August.

Lesson learned. When encountering a bug I will update my SVN checkout
first :-)

Regards, Peter.