[omniORB] CodeSet issue

[Jiang Wei]

with omniORB 4, if omniORB.cfg using a rare codeset within
libomniCodeSets4 (e.g. GBK), other program will fail if they didn't link
with libomniCodeSets4, even add "-ORBnativeCharCodeSet UTF-8" to command
line.


I made a patch in attachment to fix it.

[***@lt omni]$ nameclt -ORBnativeCharCodeSet UTF-9 -ORBnativeCharCodeSet
UTF-8 -ORBdumpConfiguration 1
...
omniORB: nativeCharCodeSet = UTF-8
omniORB: nativeWCharCodeSet = UTF-16
...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cs.diff
Type: text/x-patch
Size: 4458 bytes
Desc: not available
Url : http://www.omniorb-support.com/pipermail/omniorb-list/attachments/20090519/00a204a0/cs.bin

[Duncan Grisby]

Post by Jiang Wei
with omniORB 4, if omniORB.cfg using a rare codeset within
libomniCodeSets4 (e.g. GBK), other program will fail if they didn't link
with libomniCodeSets4, even add "-ORBnativeCharCodeSet UTF-8" to command
line.
I made a patch in attachment to fix it.

I'm not sure that's a good idea. Although you can set the native code
sets in the configuration file, it's only really the programs themselves
that can know what native code set they are expecting, so I think it's a
mistake to configure anything in the configuration file. I think it
should continue to be an error for the configuration file to ask for a
code set that isn't known.

If you continue to use your patch then note that you have incorrectly
reused omniORB exception minor codes 51 and 52 when you should have
allocated new ones.

Cheers,

Duncan.